Skip to content

Check for handling errors before returning when querying the sentinel to get the master address. #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Check for handling errors before returning when querying the sentinel to get the master address. #3350

wants to merge 1 commit into from

Conversation

kwenzh
Copy link

@kwenzh kwenzh commented Apr 17, 2025

fix: #3172

Supplement the checks for this modification: #3334

@kwenzh
Add check to the master address has been obtained
aa740ee 
Before closing the done channel, add a check to see if the master address has been obtained. If the master address has been obtained, then proceed with the subsequent operations.
@kwenzh kwenzh marked this pull request as draft April 17, 2025 11:57
@kwenzh kwenzh closed this Apr 17, 2025
@kwenzh kwenzh reopened this Apr 17, 2025
@kwenzh kwenzh marked this pull request as ready for review April 17, 2025 12:01
@ndyakov
Copy link
Member

ndyakov commented Apr 17, 2025

As discussed, #3349 is probably a better way to handle this approach, as it will also collect all errors from sentinels and report them. WDYT? If you are happy with #3349, feel free to close this PR.

@kwenzh
Copy link
Author

kwenzh commented Apr 17, 2025

As discussed, #3349 is probably a better way to handle this approach, as it will also collect all errors from sentinels and report them. WDYT? If you are happy with #3349, feel free to close this PR.

well， discuss at #3349, close issues #3172 after merge mr 3349

@kwenzh kwenzh closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sentinel cluster settings 1 node network iface down, Probability unable to query the master node, MasterAddr error： context deadline exceeded

2 participants

@kwenzh @ndyakov